Submit a Pull Request

This is a quick guide to submit a pull request, please also refer to the detailed guidelines.

  • Before submit, please rebase your code on the most recent version of main, you can do it by

    git remote add upstream [url to tvm repo]
git fetch upstream
git rebase upstream/main

  • Make sure code style check pass by typing the following command, and all the existing test-cases pass.

    # Run all lint steps.
docker/lint.sh

# To run steps individually, specify their step names on the command-line. An incorrectly
# spelled step name causes the tool to print all available steps.
docker/lint.sh <step_name> ...

# While the lint commands used should be identical to those run in CI, this command reproduces
# the CI lint procedure exactly (typically helpful for debugging lint script errors).
docker/bash.sh ci_lint ./tests/scripts/task_lint.sh

    When the clang-format lint check fails, run git-clang-format as follows to automatically reformat your code:

    # Run clang-format check for all the files that changed since upstream/main
docker/bash.sh ci_lint ./tests/lint/git-clang-format.sh upstream/main

  • Add test-cases to cover the new features or bugfix the patch introduces.

  • Document the code you wrote, see more at Write Documentation for TVM

  • Send the pull request and fix the problems reported by automatic checks.

  • Request code reviews from other contributors and improves your patch according to feedbacks.

    • To get your code reviewed quickly, we encourage you to help review others’ code so they can do the favor in return.

    • Code review is a shepherding process that helps to improve contributor’s code quality. We should treat it proactively, to improve the code as much as possible before the review. We highly value patches that can get in without extensive reviews.

    • The detailed guidelines and summarizes useful lessons.

  • The patch can be merged after the reviewers approve the pull request.

CI Environment

We use docker container to create stable CI environments that can be deployed to multiple machines. Because we want a relatively stable CI environment and make use of pre-cached image, all of the CI images are built and maintained by committers.

Upgrade of CI images can cause problems and need fixes to accommodate the new env. Here is the protocol to update CI image:

  • Send PR to upgrade build script in the repo - Can be done by a contributor, the following steps need committership.

  • Build the new docker image

  • Tag the docker image with a new version and push to tvmai

  • Update the version(most of the time increase the minor version) in the Jenkinsfile, send a PR.

  • Fix any issues wrt to the new image versions in the PR.

  • Merge the PR and now we are in new version.

  • Tag the new version as the latest.

  • Periodically cleanup the old versions on local workers

Testing

Even though we have hooks to run unit tests automatically for each pull request, it’s always recommended to run unit tests locally beforehand to reduce reviewers’ burden and speedup review process.

Running the C++ tests requires installation of gtest, following the instructions in Enable C++ Tests

C++

# assume you are in tvm source root
TVM_ROOT=`pwd`

./tests/scripts/task_cpp_unittest.sh

Python

Necessary dependencies:

pip install --user pytest Cython synr

If you want to run all tests:

# build tvm
make

./tests/scripts/task_python_unittest.sh

If you want to run a single test:

# build tvm
make

# let python know where to find tvm related libraries
export PYTHONPATH=python
rm -rf python/tvm/*.pyc python/tvm/*/*.pyc python/tvm/*/*/*.pyc

TVM_FFI=ctypes python -m pytest -v tests/python/unittest/test_pass_storage_rewrite.py

# Additionally if you want to run a single test, for example test_all_elemwise inside a file.
TVM_FFI=ctypes python -m pytest -v -k "test_all_elemwise" tests/python/frontend/tflite/test_forward.py